summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorthetaepsilon-gamedev <thetaepsilon-gamedev@noreply.users.github.com>2017-10-08 11:41:42 +0100
committerthetaepsilon-gamedev <thetaepsilon-gamedev@noreply.users.github.com>2017-10-08 11:41:42 +0100
commit7e09da50c2896e8a4bcfc6f666d5a63694e682bd (patch)
tree65e25aaa3844e98da7cfee5d5458f2b49c523d41
parent6a25e56336f98be7f91d328d6a75674450aa46a4 (diff)
downloadpipeworks-7e09da50c2896e8a4bcfc6f666d5a63694e682bd.tar
pipeworks-7e09da50c2896e8a4bcfc6f666d5a63694e682bd.tar.gz
pipeworks-7e09da50c2896e8a4bcfc6f666d5a63694e682bd.tar.bz2
pipeworks-7e09da50c2896e8a4bcfc6f666d5a63694e682bd.tar.xz
pipeworks-7e09da50c2896e8a4bcfc6f666d5a63694e682bd.zip
todo: update new flow logic items for cleanup handler work
-rw-r--r--todo/new_flow_logic.txt9
1 files changed, 5 insertions, 4 deletions
diff --git a/todo/new_flow_logic.txt b/todo/new_flow_logic.txt
index 3bc8a31..2cd15f1 100644
--- a/todo/new_flow_logic.txt
+++ b/todo/new_flow_logic.txt
@@ -3,10 +3,11 @@ Currently, only "simple" flowable nodes exist, and they will always equalise pre
A more sophisticated behaviour for this would be flowable node registration with some kind of custom callback, such that water can only flow into or out of these nodes in certain directions.
This would enable devices such as the airtight panels, sensor tubes and valves to have correct flow behaviour.
--- Implement clean-up functionality for output nodes in non-finite mode
-register.output() needs to be equipped with an extra "cleanerfn" argument, which is saved into the node's output table entry.
-When the pressure level falls below the lower level in non-finite mode, this function would be called by run_output() to e.g. remove a created water source.
-Additionally, the outputfn needs to be equipped with a flag to convey the finite mode, so that in non-finite mode the outputfn will drain pressure continuously until the pressure falls below the threshold.
+-- (may not be possible) stop removing water nodes that were not placed by outputs when off
+In non-finite mode, spigots and fountainheads will vanish water sources in their output positions, even if those output nodes did not place them there.
+This is annoying though not game-breaking in non-finite mode, where water sources can at least be easily replenished.
+Fixing this would require some kind of metadata marker on water nodes placed by spigots and fountains, such that only water sources placed while the device is "on" are removed when it is "off".
+It is debateable whether existing water sources should be marked for removal when the device turns on again.
-- Automated switching between node variants based on pressure thresholds
Within flowlogic.run(), an additional hook which would be useful is a "node changer" callback, to switch between variations of a pipe depending on pressure level.